Skip to content

fix(web-ui): don't open ui automatically on app start#5329

Merged
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
s-h-a-d-o-w:fix/dont-auto-open-ui
Jun 25, 2026
Merged

fix(web-ui): don't open ui automatically on app start#5329
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
s-h-a-d-o-w:fix/dont-auto-open-ui

Conversation

@s-h-a-d-o-w

@s-h-a-d-o-w s-h-a-d-o-w commented Jun 24, 2026 •
edited by ReenigneArcher
Loading

Copy link
Copy Markdown
Contributor

Description

This seems like a UX anti-pattern for an app that's running in the background, with only occasional config to be done. And @ReenigneArcher recently argued that a PR would be welcome.

Issues Fixed or Closed

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

ReenigneArcher
ReenigneArcher requested changes Jun 24, 2026
View reviewed changes
Comment thread packaging/linux/flatpak/scripts/sunshine.sh Outdated
Comment on lines 2 to 10

@ReenigneArcher ReenigneArcher Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

#!/bin/sh
exec sunshine "$@"

I think the script can be simplified to just this one command.

@s-h-a-d-o-w s-h-a-d-o-w Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, done.

@ReenigneArcher ReenigneArcher force-pushed the fix/dont-auto-open-ui branch from 620e0a4 to 9258984 Compare June 25, 2026 14:20
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.55%. Comparing base (7819fa2) to head (9258984).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5329     +/-   ##
=========================================
  Coverage   27.55%   27.55%             
=========================================
  Files         113      113             
  Lines       25557    25556      -1     
  Branches    11232    11231      -1     
=========================================
  Hits         7041     7041             
+ Misses      16616    15455   -1161     
- Partials     1900     3060   +1160
Flag Coverage Δ
Archlinux 11.50% <ø> (ø)
FreeBSD-amd64 13.31% <ø> (+<0.01%) ⬆️
Homebrew-macos-14 21.07% <ø> (ø)
Homebrew-macos-15 21.24% <ø> (ø)
Homebrew-macos-26 21.35% <ø> (ø)
Homebrew-ubuntu-24.04 13.53% <ø> (ø)
Linux-AppImage 12.37% <ø> (ø)
Windows-AMD64 15.27% <ø> (+<0.01%) ⬆️
Windows-ARM64 13.30% <ø> (+0.01%) ⬆️
macOS-arm64 19.23% <ø> (ø)
macOS-x86_64 18.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.cpp 24.55% <ø> (+0.03%) ⬆️

... and 68 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7819fa2...9258984. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit a84735d into LizardByte:master Jun 25, 2026
71 checks passed
@sonarqubecloud

sonarqubecloud Bot commented Jun 25, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s-h-a-d-o-w @ReenigneArcher